Fix two issues relating to a bug that caused runners not to exit #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A NoMethodError was being raised when we called `runner.finish` in the `handle_close` method of the controller. This was preventing the runner from exiting, and it wasn't clear why because the rescue was swallowing the error. Our intent is to rescue no method errors when there is no handler defined for a provided command. The new approach is to use respond_to to determine this vs rescuing all NoMethodErrors. Co-authored-by: Nate Vick <nate.vick@hint.io>
natevick
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
NoMethodErrorwas being raised when we calledrunner.finishin thehandle_closemethod of the controller. This was preventing the runner from exiting, and it wasn't clear why because the rescue was swallowing the error.Our intent is to rescue no method errors when there is no handler defined for a provided command. The new approach is to use respond_to to determine this vs rescuing all
NoMethodErrors.